adding prop to avatar link vs attach?

It depends on what you are going after.

Linking applies a parent constraint from one object to another while preserving the scene structure. On the other hand, attaching changes the scene hierarchy by parenting one object under another.